Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

statistics: remove useless partition stats cache #47201

Merged
merged 2 commits into from
Sep 22, 2023
Merged

statistics: remove useless partition stats cache #47201

merged 2 commits into from
Sep 22, 2023

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Sep 22, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #46905

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Sep 22, 2023
@hawkingrei
statistics: remove useless partition stats cache
4267d6e 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 22, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. and removed do-not-merge/needs-linked-issue labels Sep 22, 2023
@hawkingrei
update
db6c2ea 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@codecov
Copy link

codecov bot commented Sep 22, 2023 •
edited
Loading

Codecov Report

Merging #47201 (db6c2ea) into master (eef9f72) will decrease coverage by 0.3165%.
Report is 2 commits behind head on master.
The diff coverage is 87.5000%.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #47201        +/-   ##
================================================
- Coverage   72.9776%   72.6611%   -0.3165%     
================================================
  Files          1339       1360        +21     
  Lines        399847     406133      +6286     
================================================
+ Hits         291799     295101      +3302     
- Misses        89144      92258      +3114     
+ Partials      18904      18774       -130
Flag Coverage Δ
integration 32.3486% <62.5000%> (?)
unit 72.9698% <87.5000%> (-0.0078%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <ø> (ø)
parser 84.9620% <ø> (-0.0108%) ⬇️
br 48.7321% <ø> (-4.3427%) ⬇️

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 22, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 22, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-22 07:41:18.98872342 +0000 UTC m=+1468.707065637: ☑️ agreed by qw4990.
  • 2023-09-22 07:49:10.986060008 +0000 UTC m=+1940.704402225: ☑️ agreed by winoros.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qw4990, winoros, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 22, 2023
@ti-chi-bot ti-chi-bot bot merged commit db4ebd7 into pingcap:master Sep 22, 2023
@hawkingrei hawkingrei deleted the remove_useless_cache branch September 22, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@winoros winoros winoros approved these changes

@qw4990 qw4990 qw4990 approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hawkingrei @qw4990 @winoros @XuHuaiyu